Prevent duplicate notification when app is foregrounded#1
Open
sraka1 wants to merge 1 commit intorhdeck:masterfrom
Open
Prevent duplicate notification when app is foregrounded#1sraka1 wants to merge 1 commit intorhdeck:masterfrom
sraka1 wants to merge 1 commit intorhdeck:masterfrom
Conversation
Owner
|
Is there a case where one would want the notification to fire when app is in foreground? I need to re-open the code to understand present behavior, but I imagine it would be better to offer a runtime switch to suppress the UI effect of the notification rather than hardcoding that this is off at all times. Thoughts? |
Author
|
Seems okay. You could even go one step further and offer the option to send it as part of the push payload... In any case though, I’d suggest that by default it’s not duplicated (so not added to notification center if in foreground). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the title and code change pretty much says it all. This MR is already open on the base repo, but there's no activity there.
Btw, great fork and also great job with RNUG 👍Spared me quite some time...